[SYCL] Handle non-type template parameters in integration headers #18914
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
premanandrao
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
premanandrao
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
premanandrao
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
premanandrao
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
premanandrao
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Fznamznon
approved these changes
Jun 11, 2025
Contributor
|
@intel/llvm-gatekeepers This is ready for merge. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent community change llvm/llvm-project#124858 affected
how we render some non-type template parameters in the integration header. We were
generating malformed arguments of the form 'value-parameter-0-1', which obviously
led to compilation errors when including the header in host compilations.